Add realtek rts5817 soc #91486
Add realtek rts5817 soc #91486
Conversation
|
Hello @RtkFP, and thank you very much for your first pull request to the Zephyr project! |
RtkFP
force-pushed
the
add_rts5817_soc
branch
2 times, most recently
from
a20c396 to
124c8a0
Compare
soc/realtek/fingerprint/soc.yml
Outdated
| series: | ||
| - name: rts5817 |
There was a problem hiding this comment.
(non blocking comment) note you don't need a series, you can just have soc, or family and soc
There was a problem hiding this comment.
We change it to family and soc
family:
- name: fingerprint
socs:
- name: rts5817|
|
||
| if BOARD_RTS5817_MAA_EVB | ||
|
|
||
| config BOARD |
There was a problem hiding this comment.
I delete the BOARD config, is it right?
There was a problem hiding this comment.
convert to webp, put through https://tinypng.com/
| For now, the following board hardware features are supported by implemented drivers: | ||
|
|
||
| +-------------------+------------+----------------------+ | ||
| | Interface | Controller | Driver/Component | | ||
| +===================+============+======================+ | ||
| | CLOCK | on-chip | clock_control | | ||
| +-------------------+------------+----------------------+ | ||
| | FLASH | on-chip | flash | | ||
| +-------------------+------------+----------------------+ | ||
| | GPIO | on-chip | gpio | | ||
| +-------------------+------------+----------------------+ | ||
| | SPI(M/S) | on-chip | spi | | ||
| +-------------------+------------+----------------------+ | ||
| | UART | on-chip | serial | | ||
| +-------------------+------------+----------------------+ | ||
| | USB | on-chip | USB device | | ||
| +-------------------+------------+----------------------+ | ||
| | WDT | on-chip | watchdog | | ||
| +-------------------+------------+----------------------+ | ||
| | PUF | on-chip | puf | | ||
| +-------------------+------------+----------------------+ | ||
| | Temperature sensor| on-chip | sensor | | ||
| +-------------------+------------+----------------------+ |
There was a problem hiding this comment.
replace with hw directive block
| # Copyright (c) 2024 Realtek Semiconductor, Inc. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # enable clocks |
There was a problem hiding this comment.
capitalise first letter of comments
| # enable reset | ||
| CONFIG_RESET=y | ||
|
|
||
| # enable serial console | ||
| CONFIG_SERIAL=y | ||
| CONFIG_CONSOLE=y | ||
| CONFIG_UART_CONSOLE=y | ||
|
|
||
| # enable watchdog | ||
| CONFIG_WATCHDOG=y | ||
| CONFIG_WDT_DISABLE_AT_BOOT=y |
There was a problem hiding this comment.
why is reset and watchdog needed?
There was a problem hiding this comment.
Becase the watchdog is enabled by default, we have to disable it if we don`t use it, or the system will be reset by the watchdog.
And the reset driver is needed by uart, because it needs to be released from reset state before using it.
github-actions
bot
added
area: West
github-actions
bot
requested review from
carlescufi,
decsny,
gmarull,
JasonLin-RealTek,
katsuster,
martinjaeger,
MaureenHelm,
nashif,
nordic-krch,
pdgendt,
stephanosio,
swinslow and
ycsin
|
Hi, @nordicjm sorry to bother you. |
Needs to be manually approved, have approved it and results should available soon |
github-actions
bot
added
the
area: UART
RtkFP
force-pushed
the
add_rts5817_soc
branch
2 times, most recently
from
c09a47e to
34f320d
Compare
| set(VERSION ${APPVERSION}) | ||
| else() | ||
| set(VERSION 0) |
There was a problem hiding this comment.
use a lowercase variable for this, uppercase is global
| # Copyright (c) 2024 Realtek Semiconductor, Inc. | ||
| # SPDX-License-Identifier: Apache-2.0 |
|
Hi, @nordicjm , this PR is failed at the Maintainer file check[https://github.com/zephyrproject-rtos/zephyr/actions/runs/15776606080/job/44474298748?pr=91486], and I notice that this check is recently added. What can I do to pass the check? |
You have added yourself to the file but you are not part of the zephyr organisation, you would need to request access under |
|
@nashif - here is an instance matching the discussion at the Process WG. A new SoC added by a brand new contributor. This PR won't make the 4.2 release cutoff, so we can potentially decide on the new process and use this PR as a proof of concept. |
| static int realtek_rts5817_init(void) | ||
| { | ||
| cache_init(); | ||
|
|
||
| return 0; | ||
| } | ||
|
|
||
| SYS_INIT(realtek_rts5817_init, PRE_KERNEL_1, 0); |
Add support for the rts5817 MCU Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
Add clock/interrupt/pinctrl/reset dt-bindings headers for RTS5817 Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
Add Device Tree include files for RTS5817. Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
Add tool to genarate images of RTS5817 after post build stage Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
Add flash runner script to support west flash for rts5817 Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
Add clock control driver for RTS5817 Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
Add reset driver for RTS5817 Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
Add pin controller driver for RTS5817 Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
Add watchdog driver for RTS5817 Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
Add support for rts5817_maa_evb board Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
This commit adds maintainer of Realtek fingerprint SoC to maintainers.yml Signed-off-by: Darcy Lu <darcy_lu@realsil.com.cn>
|
This PR adds support for the RTS5817 fingerprint chip from Reatek, which is specially designed for fingerprint applications.
This PR includes initial support for the RTS5817 MAA evaluation board, with drivers as follows:
Please review these commits.
Thanks!